Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning for mergeable-selectors for animations in separate keyframe at-rules. #559

Closed
whaaaley opened this issue Mar 2, 2016 · 3 comments

Comments

@whaaaley
Copy link

whaaaley commented Mar 2, 2016

@keyframes pop {
  0%   { transform: scale(0); opacity: 0; }  // getting warning to merge this with the 0% below
  50%  { transform: scale(1.05); }
  75%  { transform: scale(0.95); }
  100% { transform: scale(1); opacity: 1; }  // getting warning to merge this with the 100% below
}

@keyframes active-left {
  0% { transform: translateX(-100%) rotate(45deg); } // getting warning to merge this with the 0% above
  100% { transform: translateX(0%) rotate(45deg); }  // getting warning to merge this with the 100% above
}

mergeable-selectors in animations should be scoped to the at-rule.

@DanPurdy
Copy link
Member

DanPurdy commented Mar 2, 2016

Hi there @dustindowell22

I've submitted a PR today #556 to fix the no-mergeable-selectors for the new version of Gonzales which we should be releasing soon and I can confirm that keyframes are no longer affected by the rule. 👍

So keep an eye out for the 1.6 update 😄

@whaaaley
Copy link
Author

whaaaley commented Mar 2, 2016

Awesome! Perfect timing. Thanks!

peruukki added a commit to peruukki/nhl-recap that referenced this issue Apr 2, 2016
This should no longer be needed in sass-lint 1.6.0, see
sasstools/sass-lint#559.
@DanPurdy
Copy link
Member

@dustindowell22 Sass-lint 1.6 fixes this issue 👍 thanks for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants