Add tests for helper methods #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review. Added tests for all helper functions excluding log.. Mainly because that is just a console.log and we don't use it anywhere in the code, only in dev/debugging.. The mock objects have some strange indenting but that was to pass our own JS linting tests. |
|
Yah, I've noticed sometimes ESLint's indentation freaks out and is weird for some reason… Don't know why |
donabrams
pushed a commit
to donabrams/sass-lint
that referenced
this pull request
Nov 19, 2015
Add tests for helper methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for helper methods
Opening this PR early to track progress on these tests. Will update as they happen.
References #116
DCO 1.1 Signed-off-by: Dan Purdy danjpurdy@gmail.com