-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix master - Silence output on no errors #170
Conversation
Dont merge this yet, wanted to investigate CLI warnings too as this should break them temporarily |
Closing for now, CLI testing on travis is definitely broken. |
@bgriffith @Snugug : Ok this confirms to me that the CLI isn't being tested properly, it's being loaded and tested at its latest release. 1.2.0 in this case it looks like. The changes we are making aren't being taken into account as far as the cli is concerned, we'll need to merge our changes into the globally installed sass-lint on Travis too in order to progress with this CLI development. Or at least symlink the global node modules folder to wherever we are cloning this repo to test. |
Ok thanks to the addition @mven made, this is now ready for review @bgriffith @Snugug ready for a |
👍 |
Hotfix master - Silence output on no errors
Hotfix master - Silence output on no errors
Silences error output when no warnings or errors are present in linted files. Also improves the handling of writing output to the file system with completion/error messages but no error thrown.
@Snugug - Im hoping this is what you were aiming for, I'll gladly update or revert this if it's not quite what was envisaged.
closes #141
DCO 1.1 Signed-off-by: Dan Purdy danjpurdy@gmail.com