Add maxWarnings CLI option #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exit with non-zero value when the number of warnings is greater than the maxWarning option. Easily fail CI builds without needing to update all sass-lint rules to errors. Usage: `sass-lint --max-warnings 0 -c sass-lint.config.yml sass/**/*.scss` This closes sasstools#567 Based on the eslint maxWarnings CLI option: * http://eslint.org/docs/user-guide/command-line-interface#options
|
Thanks, I'll have a look over this later 👍 closes #567 |
|
Hi @house9 Sorry for the delay here, we just finally merged all of our 1.6 work into develop which will cause a few conflicts for this PR. Would you mind updating it now and then we can look to get it merged in. Thanks! 👍 |
# Conflicts: # tests/cli.js
|
|
||
| return warningCount > 0 && warningCount > program.maxWarnings; | ||
| }; | ||
|
|
||
| var detectPattern = function (pattern) { |
There was a problem hiding this comment.
|
@DanPurdy merge conflicts have been resolved, Thanks. |
|
@house9 sorry for the delay here. This looks good to me, if you could update with the latest progress from develop then we can merge this in. Thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exit with non-zero value when the number of warnings is greater than the maxWarning option.
see #567
DCO 1.1 Signed-off-by: Jesse House jesse.house@codingzeal.com