Fix issues with rules and cli tests #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So, appveyor seems a little underpowered which means i've increased the mocha timeout limit to 10 seconds to compensate for any of the file/directory reading we have to do and child process spawning as these were causing the build to fail. Also pulled a few little issues out of some of our rules and updated our test matrices. All should be passing now but we'll wait for that lovely green tick on appveyor. This by no stretch of the imagination means sass-lint is rock solid on windows as we don't have any tests for CRLF which we know causes gonzales to behave oddly or just refuse to behave at all. Progress though at least! |
|
Looks good. Let's hope it speeds it up a little. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly to fix the appveyor failures, should prevent a few unhandled error throws too.
also fixes #445
DCO 1.1 Signed-off-by: Dan Purdy <danjpurdy@gmail.com>