Add hex validation rule #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please resolve the merge conflicts |
|
Similar question to the other PR really. As some of these rules overlap we really want to be testing each rule in isolation, I'm thinking we disable any specifically conflicting linting rules on each test to ensure we aren't seeing false positives. I think something like #70 in the future will remove this need possibly. Any thoughts? For now I'll push a change that specifically disables and enables rules on tests. |
…hex-validation # Conflicts: # tests/main.js
Some of the hex value tests overlap and flag the same issues for different reasons. To prevent this and keep our tests running in isolation I've changed the test rules to specifically enable and disable conflicting rules.
donabrams
pushed a commit
to donabrams/sass-lint
that referenced
this pull request
Nov 19, 2015
Add hex validation rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rule hex-validation will enforce all hexadecimal values are of a valid format.
Adds a new
isValidHexhelper functioncloses #82
DCO 1.1 Signed-off-by: Dan Purdy danjpurdy@gmail.com