-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add max-line-length rule #840
Merged
bgriffith
merged 4 commits into
sasstools:develop
from
DanPurdy:feature/max-line-length
Oct 26, 2016
Merged
Add max-line-length rule #840
bgriffith
merged 4 commits into
sasstools:develop
from
DanPurdy:feature/max-line-length
Oct 26, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@bgriffith this looks to fall victim to that same CRLF |
@DanPurdy Hey - is this good to go now on the |
Yup if the tests are passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
max-line-length
rule by default it is disabled in the config.It specifies a default value of 80 characters long.
If a line breaches the default or user set limit it will warn with the message:
line 1 exceeds the maximum line length of 80
closes #833
<DCO 1.1 Signed-off-by: Dan Purdy dan@danpurdy.co.uk>