Fix false positive in border-zero #890
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a false positive when `convention` is set to the integer `0` (as opposed to the string, which does work), by casting the `convention` to a string. Fixes sasstools#861
bgriffith
reviewed
Oct 17, 2016
| if (node.type === 'number' || node.type === 'ident') { | ||
| if (node.content === '0' || node.content === 'none') { | ||
| if (parser.options.convention !== node.content) { | ||
| if (('' + parser.options.convention) !== node.content) { |
There was a problem hiding this comment.
Hey @richarddewit - Thanks for the PR! Just one thing - while the solution is valid, could we be a bit more descriptive and use .toString() instead?
There was a problem hiding this comment.
Sure! I've done this just for brevity
There was a problem hiding this comment.
@richarddewit If you'd like to update it use this instead and possibly add a test where the convention is set as a number not a string in the config file then we'd be happy to merge this fix. Thanks again for taking the time! 👍
|
Closing this for #913. Thanks again @richarddewit 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do the changes you have made achieve?
This fixes a false positive when
conventionis set to the integer0(as opposed to the string, which does work), by casting theconventionto a string.Are there any new warning messages?
No
Have you written tests?
No but I've tested it manually
Have you included relevant documentation
Not necessary
Which issues does this resolve?
#861
<DCO 1.1 Signed-off-by: Richard de Wit henk.exe@gmail.com>