Don't ignore comments in no-empty-rulesets #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes the no-empty-rulesets rule trigger when a ruleset contains only comments. Closes sasstools#968.
DanPurdy
requested changes
Mar 11, 2017
There was a problem hiding this comment.
This was actually a decision taken at the beginning of the rule as far as i can remember. I'll try finding the original issue, but it was discussed that this check should be behind a flag as some people wanted to keep certain rulesets empty. (for a reason i can't remember).
|
I thought from the discussion in #968 it would be okay since rules can now be disabled via comments. Putting it in a flag isn't much work, but I guess I don't see the use case for allowing empty blocks at all. I tried searching through issues to find relevant discussions but didn't find much. |
DanPurdy
approved these changes
Aug 27, 2017
|
Yeah, you're completely right here. Sorry it's taken so long to come back to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the
no-empty-rulesetsrule trigger when a rulesetcontains only comments.
Closes #968.
DCO 1.1 Signed-off-by: Joe Einertson <jeinerts@umm>