allow skipping saving the layers #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satackey
reviewed
Aug 14, 2020
Owner
satackey
left a comment
satackey
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
test_restoreing fails and test_saving shows Skipping save.
Since core.getInput always returns a string, '' != null seems to be true even if there is no input (an empty string isn't null).
I think it would be a good idea to set the default value to true in action.yml and parse it to boolean with JSON.parse.
Co-authored-by: satackey <me+github.com@satackey.com>
Co-authored-by: satackey <me+github.com@satackey.com>
Contributor
Author
|
@satackey ahh, whoops. Thank you for the suggestion! |
|
Kudos, SonarCloud Quality Gate passed!
|
Owner
|
@btkostner I've released v0.0.6 for this. |
Contributor
Author
|
Awesome! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you skipping the whole post step of trying to save the layers. The use case here being I'm caching the build from a previous step and running tests. I don't need to save the layers again.
Use case repo: https://github.com/btkostner/neon/runs/974278660?check_suite_focus=true