Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (a11y): add accessible name to social buttons and copy button #814

Merged
merged 4 commits into from
Sep 18, 2024

Conversation

virus-rpi
Copy link
Collaborator

Changes:

  • add aria labels to all blog post social buttons
  • add aria label to the copy button
  • add translation for these labels

@virus-rpi virus-rpi requested a review from a team as a code owner September 9, 2024 15:25
Copy link

netlify bot commented Sep 9, 2024

Deploy Preview for satellytes ready!

Name Link
🔨 Latest commit dff39c5
🔍 Latest deploy log https://app.netlify.com/sites/satellytes/deploys/66eaebbbcc33360008b3e725
😎 Deploy Preview https://deploy-preview-814--satellytes.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 83 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@hofmann-felix
Copy link
Member

Awesome 🚀 I tested the changes with VoiceOver and it works great.

However, I don't feel like approving yet because I have a question about the translation keys: Since the blog is only in English, the keys are unnecessary and potentially misleading. I see there were already other translation keys for the blog before the changes. @satellytes/website-crew Does anyone know if there is a specific reason for this?

@hofmann-felix hofmann-felix mentioned this pull request Sep 13, 2024
20 tasks
@georgiee
Copy link
Member

I think it's historical. We aimed to provide a bilingual experience throughout the entire website but for the blog we did not bother to serve translated content and decided to keep it in a single language even though the content is mixed (we redirect people from German to English on this page: https://www.satellytes.com/de/blog/).

I think we can keep the PR as is as the keys are just not used right now - but ideally they are going to be used in a future iteration of the implementation (which is a separate topic). Thanks for pointing this out.

Copy link
Member

@hofmann-felix hofmann-felix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@georgiee Thanks for the clarification 🙏

Then this PR ist good to go from my side

@virus-rpi virus-rpi merged commit cf43f0d into main Sep 18, 2024
6 checks passed
@virus-rpi virus-rpi deleted the chore/a11y/blog/post/buttons branch September 18, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants