Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (a11y): make privacy checkbox keyboard accessible #816

Merged
merged 4 commits into from
Sep 19, 2024
Merged

fix (a11y): make privacy checkbox keyboard accessible #816

merged 4 commits into from
Sep 19, 2024

Conversation

virus-rpi
Copy link
Collaborator

Changes:

  • make checkbox the actual checkbox instead of having a hidden real checkbox and a fake visual checkbox

@virus-rpi virus-rpi requested a review from a team as a code owner September 10, 2024 15:10
@netlify Netlify
Copy link

netlify bot commented Sep 10, 2024 •
edited
Loading

✅ Deploy Preview for satellytes ready!

Name Link
🔨 Latest commit 6415652
🔍 Latest deploy log https://app.netlify.com/sites/satellytes/deploys/66ec2e1a7f164000083057af
😎 Deploy Preview https://deploy-preview-816--satellytes.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 85 (🟢 up 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@hofmann-felix hofmann-felix mentioned this pull request Sep 13, 2024
Open
20 tasks
hofmann-felix
hofmann-felix requested changes Sep 13, 2024
View reviewed changes
Copy link
Member

@hofmann-felix hofmann-felix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome changes 🚀 The checkbox is now keyboard accessible and the code has also become much simpler. Nevertheless, I found one small issue. Could you PTAL?

src/components/forms/checkbox/checkbox.tsx Outdated Show resolved Hide resolved
noa.santo added 2 commits September 18, 2024 16:26
chore: rename hasError prop to $hasError, so it's not passed through …
462661f 
…to the DOM element
chore: omit the spread props from the checkbox, so they are not passe…
eddc5e4 
…d through to the DOM element and no prop is given to it that should be passed through
hofmann-felix
hofmann-felix approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@hofmann-felix hofmann-felix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I can confirm that the console error is gone now

@virus-rpi virus-rpi merged commit 56c9a58 into main Sep 19, 2024
6 checks passed
@virus-rpi virus-rpi deleted the chore/a11y/career/details/privacy-checkbox branch September 19, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hofmann-felix hofmann-felix hofmann-felix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@virus-rpi @hofmann-felix