Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add button to reconfigure cookie consent #835

Merged
merged 39 commits into from
Nov 29, 2024

Conversation

virus-rpi
Copy link
Collaborator

@virus-rpi virus-rpi commented Nov 21, 2024

This PR adds a button on the data privacy page that lets the use reopen the cookie consent banner and reconfigure the preferences.
This is required according to Art. 7 GDPR point 3.

Changes:

  • added button
  • added translations for the button

image

noa.santo and others added 30 commits October 30, 2024 16:57
fix: open contact page in the same tab
Co-authored-by: Felix Hofmann <57712895+hofmann-felix@users.noreply.github.com>
@virus-rpi virus-rpi requested a review from a team as a code owner November 21, 2024 16:23
@hofmann-felix
Copy link
Member

Nice, works great from a technical point of view 🚀 And thank you for adding the link to the legal requirements in the PR description.

I think we can improve the content itself. Just adding a button on the top of the page is maybe a little bit too pragmatic. I rather imagine a small text explaining that we collect cookies for certain purposes, but only if the user agrees. This consent can be withdrawn at any time. Then you can add the button below the text. I think the Quote or the Callout component are very useful for this.

Base automatically changed from feat/add-cookie-consent to main November 28, 2024 15:05
Copy link

netlify bot commented Nov 28, 2024

Deploy Preview for satellytes ready!

Name Link
🔨 Latest commit ab955bc
🔍 Latest deploy log https://app.netlify.com/sites/satellytes/deploys/6749ed10a212160008876065
😎 Deploy Preview https://deploy-preview-835--satellytes.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 82 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Co-authored-by: Felix Hofmann <57712895+hofmann-felix@users.noreply.github.com>
Copy link
Member

@hofmann-felix hofmann-felix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. The feature works great 🚀

@virus-rpi virus-rpi merged commit 1bcf6bd into main Nov 29, 2024
6 checks passed
@virus-rpi virus-rpi deleted the feat/revoke-cookie-consent branch November 29, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants