-
Notifications
You must be signed in to change notification settings - Fork 931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PercentageFeatureSet doesn't always work when specifying assay. #8658
Comments
maxim-h
added a commit
to maxim-h/seurat
that referenced
this issue
Mar 20, 2024
maxim-h
added a commit
to maxim-h/seurat-object
that referenced
this issue
Mar 20, 2024
This is meant to help diagnose issues when assay doesn't have desired layer. For example see satijalab/seurat#8658 and discussion in satijalab/seurat#8659. The warning message might not be the prettiest, but I didn't want to go through `Layer.Seurat` method to get the assay name.
Thanks for bringing this to our attention! This indeed seems like a bug, and we will look into it. In the meantime, a workaround is to specify the |
mojaveazure
pushed a commit
to maxim-h/seurat-object
that referenced
this issue
May 3, 2024
This is meant to help diagnose issues when assay doesn't have desired layer. For example see satijalab/seurat#8658 and discussion in satijalab/seurat#8659. The warning message might not be the prettiest, but I didn't want to go through `Layer.Seurat` method to get the assay name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've been trying to run
PercentageFeatureSet
on an object that already has multiple assays, with default one beingintegrated
.I do the following, but it doesn't work:
Pretty sure it's because
PercentageFeatureSet
searches forcounts
layers, but doesn't specify whichassay
to look for layers in.seurat/R/utilities.R
Lines 1173 to 1174 in c54e57d
So, since
integrated
assay doesn't have acounts
layer nothing works.My guess is that just pushing the
assay
parameter down toLayers
call should fix this.The text was updated successfully, but these errors were encountered: