Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Use ViewTransitions #96

Closed
agriffard opened this issue Jul 25, 2023 · 4 comments
Closed

Suggestion: Use ViewTransitions #96

agriffard opened this issue Jul 25, 2023 · 4 comments

Comments

@agriffard
Copy link

Do you plan to use ViewTransitions https://astro.build/blog/astro-290/?
Or, may be, you will wait until it is not experimental anymore in 3.0?

@satnaing
Copy link
Owner

satnaing commented Aug 2, 2023

Yep, I might include it when upgrading AstroPaper to Astro v3, but for now, I'm not planning to use this feature yet.

@tanishqmanuja
Copy link
Contributor

tanishqmanuja commented Sep 11, 2023

Is there a reason for card and datetime components to be react components and not astro components, bc i can't find a way to add transition:name in react components.

satnaing added a commit that referenced this issue Sep 14, 2023
Integrate ViewTransitions API from Astro v3.

resolve #96
@satnaing
Copy link
Owner

Is there a reason for card and datetime components to be react components and not astro components, bc i can't find a way to add transition:name in react components.

@tanishqmanuja
Yes. These components are also used inside search which needs to be React component for interactivity. But in AstroPaper v3, I've tried to solve this issue by separating Astro component and React component with minimal duplicate codes.

@tanishqmanuja
Copy link
Contributor

Btw if we are not using react-dom, migration to preact will save a lot of bundle size. What's your opinion, could there be any problem that i am unaware of?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants