-
-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds GitLab CI file #208
adds GitLab CI file #208
Conversation
fully qualifies the `npm run ci` script
Like I previously said,
Just like in the https://astro-paper.pages.dev/tags/faq/ |
I have a write up here so as a post might work |
Hello @SSmale |
Sounds good, but how easy is it search in there for the code? I do like the idea of these additional features being captured in the repo as a blog post. Something like this https://github.com/withastro/docs/tree/main/.github/ISSUE_TEMPLATE might be an idea to have as well as https://github.com/withastro/docs/blob/main/.github/PULL_REQUEST_TEMPLATE.md so that there is some documented guidance on what you want people to capture where |
I tried to deploy with the gitlab-ci file from the pull request but the deploy failed at the first step. Before I used a simple deploy script like this but it also fails, probably because nom run build works differently than with other astro projects. Anyone has any clue how I can get my deploy working?
|
Hey, do you have a copy of the error message? Below is a full copy of the file I use to deploy my blog, this line is very important for reasons I can't remember
|
Hey, |
Can you try taking out the 'run' part? You can just use install to check everything is setup and then investigate this bit after. |
|
Do you have all the files from the theme, seems like there might be something missing. Can you provide a link to your repo? |
It's a private Gitlab Server, but I just started from scratch cloning the repo, merging the gitlab-ci branch into master and run the pipeline, so there should be no files missing. Now the pipeline complains about |
Might be that you have an issue with the docker image. Maybe try running the commands locally to check they are all still valid on your version |
don't you think it could be just a blog post? Edit: everyone gonna use different ci/cd tool to deploy, IMO it could be a blog post. |
Hello @SSmale, Thank you so much for your contribution! I really appreciate your effort in adding a GitLab CI file. However, at this time, I believe this change might be more suitable as part of a discussion or even a how-to guide for users who want to integrate GitLab with AstroPaper. If you're not planning to create either, I’ll happily redirect users to your blog post. I’m closing this PR for now, but I’d love to see this idea explored further. Thanks again for your work! |
For anyone looking to use GitLab for hosting, this is the configuration I used to verify the code and bundle and push it