Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove recent posts section if there's no post #238

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

satnaing
Copy link
Owner

Changes made:

  • Removed the recent posts section if there is no post under the recent section.
  • Eliminated unnecessary
    tags when there are no recent posts.
  • Extracted all-links from the recent section.

Closes: #204

Changes made:
- Removed the recent posts section if there are no posts under the recent section.
- Eliminated unnecessary <Hr /> tags when there are no recent posts.
- Extracted all-links from the recent section.

Closes: #204
Copy link
Contributor

@SSmale SSmale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

Is it worth adding the filters for featured and not featured into the postfilters file so that they can be named?

@satnaing
Copy link
Owner Author

Is it worth adding the filters for featured and not featured into the postfilters file so that they can be named?

I don't think it's necessary since featuredPosts and recentPosts are being used only in index.astro.

@satnaing satnaing merged commit 629dbfd into main Jan 18, 2024
2 checks passed
@satnaing satnaing deleted the fix/remove-recent-section-if-no-posts branch January 18, 2024 03:08
gyunseo added a commit to gyunseo/gyunseo.github.io that referenced this pull request Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recent posts is empty if all the current posts are marked as featured
2 participants