Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Release possible? #90

Open
Klaus-Tockloth opened this issue Dec 10, 2018 · 4 comments
Open

New Release possible? #90

Klaus-Tockloth opened this issue Dec 10, 2018 · 4 comments

Comments

@Klaus-Tockloth
Copy link

The current release is nearly a year old. Is it possible to publish a new release?
@cameracker
Copy link

cameracker commented Dec 10, 2018 •
edited
Loading

Probably not. #84

@Klaus-Tockloth
Copy link
Author

Thanks for pointing to the fork package https://github.com/gofrs/uuid. I have switched to it.

@wweir
Copy link

wweir commented Dec 17, 2018

A timely release is so important for golang semver package management tool, such as dep / glide and go modules.
So, please release quickly.

@cameracker
Copy link

cameracker commented Dec 17, 2018 •
edited
Loading

If this package is not going to release to your needs, get a different one. There was a huge stink about a critical vulnerability that was left outstanding in this repo for 6 months and it resulted in a permanent, community maintained fork. See #84 like I posted earlier. Go look at gofrs/uuid for a drop in replacement.

At this point appeals to satori is kind of like shouting into a black hole. I dont know what he has going on but he hasn’t been around to reliably release or tag this repo. This repo should probably be archived, frankly.

@trestoa trestoa mentioned this issue Dec 19, 2018
Closed
whilei added a commit to whilei/leaps that referenced this issue Dec 22, 2018
@whilei
lib/util: Update UUID vendor
18a0176 
It appears github.com/satori/go.uuid is functionally deprecated,
and has been superceded by github.com/gofrs/uuid.

- satori/go.uuid#84
- satori/go.uuid#90

This came to my attention because of un-tagged changes to
satori/go.uuid that changed the signature of uuid.NewV4()
from a single return val to two, resulting in:

$ go get github.com/Jeffail/leaps/cmd/...
warning: ignoring symlink /Users/ia/go/src/github.com/Jeffail/leaps/cmd/leaps/www
warning: ignoring symlink /Users/ia/go/src/github.com/Jeffail/leaps/cmd/leaps/www
# github.com/Jeffail/leaps/lib/util
go/src/github.com/Jeffail/leaps/lib/util/uuid_gen.go:51:19: multiple-value uuid.NewV4() in single-value context

Of course running 'dep ensure' fixed this issue, but
it seems like this project should use the 'longer fork'
of this dependency in any case.

This change does NOT address the 'what to do with the
error value' question; it just ignores the possible error.
@whilei whilei mentioned this issue Dec 22, 2018
Merged
dmitshur added a commit to shurcooL/home that referenced this issue Dec 22, 2018
@dmitshur
Switch to github.com/google/uuid dependency.
e3254af 
It seems to be more well maintained and reliable at this time.

google/uuid works out of box with Go modules, because the most recently
tagged version is compatible with master (at this time, they're equal).
On the other hand, using satori/go.uuid requires reverting back to an
older API because its latest tag is more significantly behind master.
See satori/go.uuid#90, satori/go.uuid#82, satori/go.uuid#76.
@kevindelgado kevindelgado mentioned this issue Jul 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wweir @Klaus-Tockloth @cameracker