Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add slipid44 for DYDX #1861

Merged
merged 4 commits into from
Feb 11, 2025
Merged

Conversation

murdererbrain
Copy link
Contributor

This PR adds support for the dYdX network to SLIP-0044 .

@prusnak
Copy link
Member

prusnak commented Feb 8, 2025

19000119 is not 0x04812447

so which one is it?

@murdererbrain
Copy link
Contributor Author

updated coin type dydx

@murdererbrain
Copy link
Contributor Author

Please check again
thank you
@prusnak

@prusnak
Copy link
Member

prusnak commented Feb 10, 2025

Please check again

the numbers still do not match:

hex(22000118) = 0x14fb1f6
0x04812447 = 75572295

please ask some developer to provide the numbers

@murdererbrain
Copy link
Contributor Author

The part you announced has been fixed
Thank you for checking again.
@prusnak

@prusnak prusnak merged commit 9af0e11 into satoshilabs:master Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants