-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webpack v2.1.0-beta.23 and later breaks quik #81
Comments
@BSiepert Thanks for the report. I'll investigate ASAP. |
@BSiepert Meanwhile, how did you force it to use v2.1.0-beta.22? |
@felippenardi see the diff in the linked pull request. In short you just need to edit quik's package.json line for webpack and remove the carat at the beginning of the line to change |
@BSiepert How do I generate a distribution version after modifying it? |
I'm not sure what you mean by "generate a distribution version"; in my case I modified the package.json in place wherever quik got installed , probably did an npm install and things worked. |
@BSiepert I tried that and ran |
Fyi @felippenardi this is probably a really unintuitive way to do it, but I just grabbed the |
sorry for not looking into this issue. just a little busy with work an other things. for now it's hardcoded (thanks @BSiepert ), I'll take a look when I get time. If anyone has time to take a look, it'll be great! |
Fixed by 08fe9fd |
If you refer to webpack/webpack#3018 , it seems there was a breaking change in how webpack validates configuration objects. I was able to get quik to work by forcing it to use v2.1.0-beta.22, however a smarter person than I will have to figure out how to adjust how quick is using webpack's configuration object.
The text was updated successfully, but these errors were encountered: