Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack v2.1.0-beta.23 and later breaks quik #81

Closed
siddacious opened this issue Sep 21, 2016 · 9 comments
Closed

Webpack v2.1.0-beta.23 and later breaks quik #81

siddacious opened this issue Sep 21, 2016 · 9 comments

Comments

@siddacious
Copy link
Contributor

If you refer to webpack/webpack#3018 , it seems there was a breaking change in how webpack validates configuration objects. I was able to get quik to work by forcing it to use v2.1.0-beta.22, however a smarter person than I will have to figure out how to adjust how quick is using webpack's configuration object.

@satya164
Copy link
Owner

@BSiepert Thanks for the report. I'll investigate ASAP.

@felippenardi
Copy link

@BSiepert Meanwhile, how did you force it to use v2.1.0-beta.22?

@siddacious
Copy link
Contributor Author

@felippenardi see the diff in the linked pull request. In short you just need to edit quik's package.json line for webpack and remove the carat at the beginning of the line to change
"webpack": "^2.1.0-beta.22",
to
"webpack": "2.1.0-beta.22",

@felippenardi
Copy link

@BSiepert How do I generate a distribution version after modifying it?

@siddacious
Copy link
Contributor Author

I'm not sure what you mean by "generate a distribution version"; in my case I modified the package.json in place wherever quik got installed , probably did an npm install and things worked.

@MrSkinny
Copy link

MrSkinny commented Oct 7, 2016

@BSiepert I tried that and ran npm install but it failed on trying to recreate the dist folder saying that src doesn't exist. Now quik from the CL doesn't run at all.

@MrSkinny
Copy link

MrSkinny commented Oct 7, 2016

Fyi @felippenardi this is probably a really unintuitive way to do it, but I just grabbed the quik source from this repo and put it in a temp folder, changed the webpack version in package.json, then ran npm install. Then I copied the resulting bin/ dist/ and node_modules/ folders into the globally installed version. Now it appears to working without an error!

@satya164
Copy link
Owner

satya164 commented Oct 8, 2016

sorry for not looking into this issue. just a little busy with work an other things. for now it's hardcoded (thanks @BSiepert ), I'll take a look when I get time.

If anyone has time to take a look, it'll be great!

@satya164
Copy link
Owner

Fixed by 08fe9fd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants