add visual example code #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loyalchow
suggested changes
Aug 19, 2020
| chromeOptions.AddAdditionalCapability("sauce:options", sauceOptions, true); | ||
| chromeOptions.AddAdditionalCapability("sauce:visual", visualOptions, true); | ||
|
|
||
| driver = new RemoteWebDriver(new Uri(String.Format("{0}://{1}:{2}/wd/hub", seleniumProtocol, seleniumHost, seleniumPort)), chromeOptions.ToCapabilities(), TimeSpan.FromSeconds(600)); |
There was a problem hiding this comment.
Looking at this again, I think there's too many environment variables making it potentially hard to read for an end user.
Can you simplify to:
new Uri("https://hub.screener.io:443/wd/hub")
|
|
||
| * Add all the necessary environment variables | ||
| ``` | ||
| setx SELENIUM_PROTOCOL "http" |
There was a problem hiding this comment.
As mentioned in another comment, let's simplify and remove the SELENIUM_PROTOCOL, SELENIUM_HOST, and SELENIUM_PORT environment variables
| public string sauceUserName = Environment.GetEnvironmentVariable("SAUCE_USERNAME"); | ||
| public string sauceAccessKey = Environment.GetEnvironmentVariable("SAUCE_ACCESS_KEY"); | ||
| public string screenerApiKey = Environment.GetEnvironmentVariable("SCREENER_API_KEY"); | ||
| public string seleniumProtocol = Environment.GetEnvironmentVariable("SELENIUM_PROTOCOL"); |
There was a problem hiding this comment.
As mentioned in another comment, let's simplify and remove the SELENIUM_PROTOCOL, SELENIUM_HOST, and SELENIUM_PORT environment variables and checks in this file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nikolay, can you verify this code? I think it only works on Windows.
Also, you need to be on VPN for it to work as is.
Before merging we need to update the URL to https://hub.screener.io/wd/hub
Feel free to do whatever with this code to get it to work (move it, rewrite it, etc) :)
Let me know if I can help.