Add support for proxy protocol in martian #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n with proxy header If connection provides proxy protocol header, when reading requests set http.Request.RemoteAddr to source IP address from proxy header.
--proxy-protocol-read-header-timeout <duration> (default 5s) (env FORWARDER_PROXY_PROTOCOL_READ_HEADER_TIMEOUT)
The amount of time to wait for PROXY protocol header if present.
mmatczuk
changed the title
mmatczuk
changed the title
Enable proxy protocol by default in tests. Add tests to check if XFF header is properly updated.
mmatczuk
force-pushed
the
mmt/proxyproto_v2
branch
from
62b7f95
to
e5f55f7
Compare
|
I'm beginning to think we made a mistake with putting tls to the listener. |
Why? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is version of #915 that implements reading proxy headers in martian.
This has many benefits unfortunately this approach is wrong so I'm sending it for information purposes only.
This means we need implementation in forwarder.Listener I'd send another patch.