Convert docker-based action to typescript-based one #12
Conversation
this change will close saucelabs#11 by running `docker container stop` after the workflow run.
Dockerfile and entrypoint.sh are now needless, simply remove them from the Git repository.
| import optionMappingJson from './option-mapping.json' | ||
|
|
||
| const CONTAINER_VERSION = '4.6.2' | ||
| const LOG_FILE = '/srv/sauce-connect.log' |
There was a problem hiding this comment.
Is it possible to upload this log file as asset?
There was a problem hiding this comment.
possible, refs https://github.com/actions/toolkit/tree/main/packages/artifact
Is it OK to make this change in this PR? I assume that we can handle this new feature in another PR.
There was a problem hiding this comment.
I assume that we can handle this new feature in another PR.
Feel free to add it as part of this PR. If not, let's create an issue for it an tackle it afterwards.
| import {wait} from './wait' | ||
| import optionMappingJson from './option-mapping.json' | ||
|
|
||
| const CONTAINER_VERSION = '4.6.2' |
There was a problem hiding this comment.
Making this an GH Action option would be great. Let's do this in a separate PR though.
Input, output and behavior are not changed. Just fix #11. Performance could be improved. |
| "docker:tag": "docker tag saucelabs/sauce-connect-action saucelabs/sauce-connect-action:$npm_package_version", | ||
| "test": "run-p test:*", | ||
| "test:setup": "http-server ./test -p 8080 > /dev/null 2>&1 &", | ||
| "test:run": "node ./test/test.js" |
There was a problem hiding this comment.
Could we get back this test?
|
It looks like this also changes it to wait for the sc.ready file? Great job! I was trying to figure out how to do this before with the docker version (so that we weren't waiting 30 seconds each time, and it would fail on an error) but was struggling to access the file. I think it was related to the directory being mounted on the host not the container. |
|
Can you reproduce the issue? |
|
Sorry it works for us too with the current version (although it looks like the ready file gets written even on a concurrency error) :) I was trying to achieve the same thing with the docker version but failed |
To close #11, convert the docker-based action to typescript-based one, then we can use
postto run the cleanup operation.Note that the configurations for build tools are copied from the official template project. I hope that it reduces the barrier to contribute for other users.