Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve instruction for creating a source map upload URL #2441

Closed
wants to merge 10 commits into from
Closed

Improve instruction for creating a source map upload URL #2441

wants to merge 10 commits into from

Conversation

rick-bt
Copy link
Collaborator

@rick-bt rick-bt commented Sep 14, 2023 •
edited
Loading

BT-668 Update Source Maps doc

Description

  1. The upload URL is critical to source maps. The current link to generating the URL is somewhat hidden, and not enough context is provided.
  2. Support for a configuration file has been extended, and is now the preferred integration method.

Motivation and Context

Users were failing to correctly generate an upload URL.
The configuration file will improve integration success.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation fix (typos, incorrect content, missing content, etc.)

@rick-bt rick-bt marked this pull request as draft September 20, 2023 22:40
@rick-bt
Copy link
Collaborator Author

rick-bt commented Sep 20, 2023

This needs review by Backtrace engineering. I'll take it out of draft when I have their approval.

@rick-bt rick-bt marked this pull request as ready for review September 21, 2023 19:09
@rick-bt
Copy link
Collaborator Author

rick-bt commented Sep 21, 2023

@lauramthomas - This is ready for final review and merge.

@rick-bt rick-bt closed this Sep 26, 2023
@rick-bt rick-bt deleted the rick/improve-sourcemap-url-instructions branch September 26, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauramthomas lauramthomas lauramthomas approved these changes

@konraddysput konraddysput konraddysput approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rick-bt @konraddysput @lauramthomas