Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding electron.md for Electron beta documentation #2446

Merged
merged 14 commits into from
Dec 4, 2023

Conversation

mfranzonello2
Copy link
Contributor

Description

Created a new page for Electron testing documentation for our beta trial.

Motivation and Context

Electron is a framework for desktop, Chromium-based apps (like Slack) that Sauce Labs is beta testing with customers. It sits between web apps and mobile apps, so it needs it's own documentation on how to use. Note that I did not update the sidebar file, because I don't want this to show on the sidebar yet, just needs a place to live in our docs. We might want to move this to another section when we go to full release.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation fix (typos, incorrect content, missing content, etc.)

Added documentation for Electron beta testing. Not currently adding this to the sidebar until we're closer to launch, as we might also want to move it from webapps to a different section.
fixed typo in JavaScript code example
typos in JavaScript example + tab
removed the JavaScript example code completely for now
@github-actions
Copy link

Deploy preview ready for 2446!
https://docs.dev.saucelabs.net
built from 2227181

Copy link
Contributor

@wswebcreation wswebcreation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments, can you please take a look?

docs/web-apps/automated-testing/electron.md Outdated Show resolved Hide resolved
docs/web-apps/automated-testing/electron.md Show resolved Hide resolved
docs/web-apps/automated-testing/electron.md Outdated Show resolved Hide resolved
docs/web-apps/automated-testing/electron.md Show resolved Hide resolved
docs/web-apps/automated-testing/electron.md Outdated Show resolved Hide resolved
docs/web-apps/automated-testing/electron.md Outdated Show resolved Hide resolved
docs/web-apps/automated-testing/electron.md Show resolved Hide resolved
docs/web-apps/automated-testing/electron.md Outdated Show resolved Hide resolved
docs/web-apps/automated-testing/electron.md Outdated Show resolved Hide resolved
docs/web-apps/automated-testing/electron.md Outdated Show resolved Hide resolved
@mfranzonello2 mfranzonello2 requested a review from a team as a code owner November 30, 2023 19:22
Copy link

Deploy preview ready for 2446!
https://docs.dev.saucelabs.net
built from 97793e5

Copy link

Deploy preview ready for 2446!
https://docs.dev.saucelabs.net
built from f0881a5

mfranzonello2 and others added 2 commits November 30, 2023 14:29
Co-authored-by: Wim Selles <wim@wswebcreation.nl>
Co-authored-by: Wim Selles <wim@wswebcreation.nl>
Copy link

Deploy preview ready for 2446!
https://docs.dev.saucelabs.net
built from cf9568e

Copy link

Deploy preview ready for 2446!
https://docs.dev.saucelabs.net
built from d87154b

mfranzonello2 and others added 2 commits November 30, 2023 14:45
Co-authored-by: Wim Selles <wim@wswebcreation.nl>
Co-authored-by: Wim Selles <wim@wswebcreation.nl>
Copy link

Deploy preview ready for 2446!
https://docs.dev.saucelabs.net
built from 537224e

Copy link

Deploy preview ready for 2446!
https://docs.dev.saucelabs.net
built from 09e38fc

Copy link

github-actions bot commented Dec 4, 2023

Deploy preview ready for 2446!
https://docs.dev.saucelabs.net
built from b69a48a

@mfranzonello2 mfranzonello2 dismissed wswebcreation’s stale review December 4, 2023 14:06

will get remaining comments into next update

Copy link
Collaborator

@alexplischke alexplischke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing sidebar update? Can't see it in the menu.

@mfranzonello2
Copy link
Contributor Author

mfranzonello2 commented Dec 4, 2023 via email

Co-authored-by: Alex Plischke <alex.plischke@saucelabs.com>
Co-authored-by: Alex Plischke <alex.plischke@saucelabs.com>
Copy link

github-actions bot commented Dec 4, 2023

Deploy preview ready for 2446!
https://docs.dev.saucelabs.net
built from 3a8d343

Copy link

github-actions bot commented Dec 4, 2023

Deploy preview ready for 2446!
https://docs.dev.saucelabs.net
built from 8163052

Copy link

github-actions bot commented Dec 4, 2023

Deploy preview ready for 2446!
https://docs.dev.saucelabs.net
built from 1f6183b

@mfranzonello2 mfranzonello2 merged commit 3fdd02c into main Dec 4, 2023
6 checks passed
@mfranzonello2 mfranzonello2 deleted the mfranzonello2-electron branch December 4, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants