Add details of Electron automated binary detection. #3055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview ready for 3055! |
tianfeng92
reviewed
Jan 8, 2025
|
|
||
| ### Binary location | ||
|
|
||
| The `binary_location` is the folderpath and filename of your Electron executable within your zip file structure. | ||
| The `binary_location` is the folderpath and filename of your Electron executable within your archive file structure. |
There was a problem hiding this comment.
Make the lint bot happy. 😄
Suggested change
| The `binary_location` is the folderpath and filename of your Electron executable within your archive file structure. | |
| The `binary_location` is the folderpath and filename of your Electron executable in your archive file structure. |
There was a problem hiding this comment.
I didn't even write THAT one 😆
|
|
||
| For example, if your zip file is structured like this: | ||
| You don't normally need to provide this field. If you omit it, our systems will do their best to find the executable within the file you uploaded. |
There was a problem hiding this comment.
Suggested change
| You don't normally need to provide this field. If you omit it, our systems will do their best to find the executable within the file you uploaded. | |
| You don't normally need to provide this field. If you omit it, our systems will do their best to find the executable in the file you uploaded. |
tianfeng92
approved these changes
Jan 8, 2025
|
Deploy preview ready for 3055! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added details of automated detection of executable binaries in Electron applications.
Motivation and Context
DVI task
Types of Changes