-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added release action #84
Conversation
Codecov Report
@@ Coverage Diff @@
## master #84 +/- ##
=======================================
Coverage 99.21% 99.21%
=======================================
Files 6 6
Lines 383 383
Branches 84 84
=======================================
Hits 380 380
Misses 3 3 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about we get rid of Travis all together and also have the tests run on GitHub Actions?
- name: Setup Node version | ||
uses: actions/setup-node@v1 | ||
with: | ||
node-version: 10.15.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should update the node version to latest LTS (including in .nvmrc
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, this action (setup-node
) doesn't support keywords like lts
, see actions/setup-node#58. I can bump Node version to match current LTS, but until the PR is merged we will need to do it manually.
It's a good idea, although I would like to do it in other PR maybe, because we will introduce too many changes. What do you think? |
I found pretty nice tool for testing Github Actions locally (via Docker containers) - https://github.com/nektos/act. Unfortunately, we still need to test the workflow after merging it to master, because act doesn't support any actions that requires Github API like artifacts and caching. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Lets wait for Christian's approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I created a follow up ticket: #85
This PR adds manual release action via Github Actions. Also it adds removing ANSI escape codes to snapshot serialization in order to make test pass on all platforms.