-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Espresso SDK #138
Espresso SDK #138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please add comments to the public API?
visual-espresso/visual/src/androidTest/java/com/saucelabs/visual/SmokeTest.java
Outdated
Show resolved
Hide resolved
visual-espresso/visual/src/main/java/com/saucelabs/visual/VisualApi.java
Show resolved
Hide resolved
visual-espresso/visual/src/main/java/com/saucelabs/visual/VisualApi.java
Outdated
Show resolved
Hide resolved
visual-espresso/visual/src/main/java/com/saucelabs/visual/VisualApi.java
Outdated
Show resolved
Hide resolved
visual-espresso/visual/src/main/java/com/saucelabs/visual/VisualBuild.java
Outdated
Show resolved
Hide resolved
visual-espresso/visual/src/main/java/com/saucelabs/visual/exception/VisualApiException.java
Show resolved
Hide resolved
visual-espresso/visual/src/main/java/com/saucelabs/visual/graphql/GraphQLClient.java
Outdated
Show resolved
Hide resolved
visual-espresso/visual/src/main/java/com/saucelabs/visual/junit/TestMetaInfoRule.java
Outdated
Show resolved
Hide resolved
A lot of the code here looks similar-ish to the Java client. Can none of that be imported and used here as a dependency somehow? |
@omacranger That would be super convenient however it brings also some problems that complicates the implementation. Importing Java client brings transitive dependencies that are not compatible with Android environment, considering the target Android API (apache httpclient, graphql-java etc.). Those dependencies need to be excluded explicitly and need to be maintained for the future versions of java client if new ones show up. NVM, I've managed to get it running by changing the main package name from com.saucelabs.visual to com.saucelabs.visual.espresso. There's a clear separation of packages now so no more class/method loading problems arise. |
Open points:
Environment variable handling needs to be adapted to Android best practicesHandled it with buildConfig and localPropertiesBuilder classes where appropriate (VisualClient, VisualCheckOptions, BuildAttributes etc.)ProvidedUse default Android http client instead of Apache'sSwitched to using apollo graphql client