New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sheets-] fix error adding col to sheet with no visible cols #2614

Merged

anjakefala merged 2 commits into saulpw:develop from midichef:addcol_firstcol

Dec 2, 2024

Contributor

midichef commented Nov 29, 2024

Adding columns to an empty sheet gives an error: echo hi |vd then - then i.

Traceback (most recent call last):
  File "addcol-incr", line 1, in <module>
    'VisiData: a curses interface for exploring and arranging tabular data'
  File "/home/midichef/.venv.vd_develop/lib/python3.12/site-packages/visidata/sheets.py", line 579, in addColumnAtCursor
    index = self.columns.index(ccol)+1
ValueError: <Column: > is not in list


          [sheets-] fix error adding col to sheet with no visible cols

c1f32eb

anjakefala added the waiting on maintainer label

saulpw approved these changes

View reviewed changes

Owner

saulpw left a comment

Thanks, @midichef !


          [tests-] add test for adding column to empty sheet

c0bd55b

anjakefala merged commit d055887 into saulpw:develop

8 of 14 checks passed

midichef deleted the addcol_firstcol branch

December 3, 2024 21:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting on maintainer