Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x dev #39

Merged
merged 2 commits into from
Jul 24, 2023
Merged

3.x dev #39

merged 2 commits into from
Jul 24, 2023

Conversation

coolsam726
Copy link
Contributor

No description provided.

@coolsam726 coolsam726 merged commit 18dcd24 into 3.x Jul 24, 2023
@what-the-diff
Copy link

what-the-diff bot commented Jul 27, 2023

PR Summary 😊

It looks like this pull request is all about modifying and improving a couple of files. Let's break down what's happening in a fun and easy-to-grasp manner. 😄

Changes to our vessel, ModuleMakePanelCommand.php 🚀

  • New Parking Spot!: A new property, $basePath, is being added to park our module with ease.

  • New Module and Guidance System!: Not only are we getting a new $module property, but also the handy handle() method to control it.

  • Intelligent Handling!: We are enhancing the handle() method to become smarter by incorporating conditions and updating the logic. We always love smart! 🧠

  • Getting a Route: We're adding the getModuleNamespace() method for smoother navigation where we're going.

  • Reading and Writing: With the readModuleJson() and writeToModuleJson() methods, our module will read instructions (in JSON format) and log reports, just like a good astronaut. 📕✏

Adventures in LaravelModulesServiceProvider.php 🌠

  • No More Extra Baggage!: We've decided to lighten the load by removing use Filament\FilamentServiceProvider; import from the field.

  • Updated Guide: The register() method has been updated to guide our new module more efficiently.

  • New Registration!: We've added the method registerPanels() to ensure any panels of our module are recognized and registered properly.

Little Tidy-up in TestCase.php 🧹

  • Uncluttered!: The use Coolsam\FilamentModules\ModulesServiceProvider; import has been shrunk and thrown away to clean up the code.

Keep going team, make those bits and bytes dance! 💃🕺💻

marco76tv pushed a commit to laraxot/filament-modules that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant