-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transfer cancellation and notifications #432
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this disables the file progress command from the CLI tools for now, need to restore this command later.
When we have multiple clients then a concurrent_transfers settings is multiplied by the number of clients for uploads so we divide by the number of clients to get as close as possible to the target concurrent_transfers.
Fatal error on connection refused breaks the retry logic that we already have test specs for so we need request retry logic with exponential backoff.
Also handle backpressure on websocket notification channel.
Need to await the call to send() on the mpsc::Sender.
A transfer_id is consistent for a given file, operation and origin so that callers can see if an inflight transfer corresponds to an existing inflight transfer. For example, this can be used by a UI to remove a previously failed transfer notification when the same transfer is re-queued.
Otherwise uploading very large files will never complete.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
file_transfers_offline_*
test specsfile_transfers_late_upload
test specCloses #434 and closes #433.