Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use protocol buffers for wire protocol #450

Merged
merged 104 commits into from
Jun 19, 2024
Merged

Use protocol buffers for wire protocol #450

merged 104 commits into from
Jun 19, 2024

Conversation

tmpfs
Copy link
Collaborator

@tmpfs tmpfs commented Jun 16, 2024 •
edited
Loading

  • CommitState
  • ChangeSet
  • UpdateSet
  • SyncStatus
  • Patch
  • MaybeDiff
  • SyncPacket
  • Comparison
  • SyncCompare
  • SyncDiff
  • FileSet
  • FileTransfersSet
  • Update file endpoints for new protobuf types
  • Use protobuf for websocket notification types (MergeOutcome etc.)
  • Remove obsolete MIME types
  • Remove obsolete Noop variants
  • Prune obsolete binary-stream encoding implementations
  • Use profobuf for the relay encoding
  • Pass servers in PairingConfirm
  • Encoding and decoding should support running async via spawn_blocking
  • Do not expose WireOrigin
  • Use oneoff for enum types (CheckedPatch etc.)
  • Test specs for encoding and decoding all types
    • Files module types
    • Notifications module types
    • Sync module types

Refactor of sync types

  • Update merge and force_merge in identity and folder event logs
  • Handle diff and patch functions in event log
  • Fix SyncError handling
  • Move storage transfer directory to sos-net

@tmpfs tmpfs self-assigned this Jun 16, 2024
tmpfs added 27 commits June 16, 2024 17:18
@tmpfs
Update scan endpoint to use protobuf for wire.
427f7de
@tmpfs
Remove obsolete types.
a0d60de
@tmpfs
Prepare module for diff wire types.
3977685
@tmpfs
Prepare types for the diff endpoint.
e4f1b14
@tmpfs
Use new protobuf diff types.
85bf101
@tmpfs
Prepare patch wire types.
2621a1e
@tmpfs
Prepare wire checked patch handling.
b151dd7
@tmpfs
Use protobuf for patch endpoint.
14e6278
@tmpfs
Remove Default implementations and Noop variant.
3515e63
@tmpfs
Define WireCommitState type.
ec20aa1
@tmpfs
Stub proto for sync types.
107839d
@tmpfs
Prefer bytes for wire folder identifiers.
3d946ab
@tmpfs
Use blanket implementation for wire encoding and decoding.
a5065de
@tmpfs
Add types to the sync protobuf module.
6301fc1
@tmpfs
Define ChangeSet and UpdateSet protobuf messages.
f223bb8
@tmpfs
Defining more sync types as protobuf.
8917141
@tmpfs
Do not include leaves in Comparison::Contains variant.
fc9d155
@tmpfs
Prepare type conversion for Comparison.
f3fbc7e
@tmpfs
Define SyncPacket as protobuf.
47c5815
@tmpfs
Protocol binding types for the sync file types.
7c70c7a
@tmpfs
Implement more type bindings.
3196388
@tmpfs
Draft implementation for MaybeDiff type bindings.
e209f93
@tmpfs
Fix error conversion on bindings.
701347d 
Declare associated Error type for TryFrom implementations as
protocol::Error.
@tmpfs
Bindings for ChangeSet type.
f136b1a
@tmpfs
Use protobuf ChangeSet for create_account() and fetch_account().
9bd02a4
@tmpfs
Remove obsolete encoding for ChangeSet.
45c648c
@tmpfs
Use protobuf implementation for UpdateSet.
90d5fd2
tmpfs added 15 commits June 18, 2024 15:30
@tmpfs tmpfs merged commit 5a6808f into main Jun 19, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tmpfs tmpfs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tmpfs