Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reused c.p.k.c.Rule.VisitorModifier.RunAfterRule #1310

Merged
merged 16 commits into from
May 27, 2022
Merged

Conversation

nulls
Copy link
Member

@nulls nulls commented May 27, 2022

What's done:

  • added a wrapper for rule with c.p.k.c.Rule.VisitorModifier.RunAfterRule is pointed to prev rule

This pull request closes #1309

nulls added 7 commits May 27, 2022 11:40
### What's done:
* added a wrapper for rule with c.p.k.c.Rule.VisitorModifier.RunAfterRule is pointed to prev rule
### What's done:
* fixed condition
### What's done:
* reused typealias
### What's done:
* fixed import ordering
### What's done:
* fixed formatting issues
@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #1310 (cf4c438) into master (b895181) will increase coverage by 0.01%.
The diff coverage is 93.33%.

@@             Coverage Diff              @@
##             master    #1310      +/-   ##
============================================
+ Coverage     82.05%   82.07%   +0.01%     
- Complexity     2533     2534       +1     
============================================
  Files           105      105              
  Lines          7201     7214      +13     
  Branches       2058     2061       +3     
============================================
+ Hits           5909     5921      +12     
  Misses          346      346              
- Partials        946      947       +1     
Flag Coverage Δ
unittests 82.07% <93.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...cqfn/diktat/ruleset/rules/DiktatRuleSetProvider.kt 96.99% <93.33%> (-0.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b895181...cf4c438. Read the comment docs.

@nulls nulls marked this pull request as ready for review May 27, 2022 11:00
@nulls nulls requested review from petertrr and orchestr7 May 27, 2022 11:00
@nulls nulls mentioned this pull request May 27, 2022
5 tasks
nulls added 2 commits May 27, 2022 14:25
### What's done:
* prevRule is NotNull now
### What's done:
* fixed formatting issue
@nulls nulls enabled auto-merge (squash) May 27, 2022 11:39
@nulls nulls self-assigned this May 27, 2022
@nulls nulls mentioned this pull request May 27, 2022
Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nulls nulls merged commit f7c9c8a into master May 27, 2022
@nulls nulls deleted the feature/ordering#1309 branch May 27, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reuse com.pinterest.ktlint.core.Rule.VisitorModifier.RunAfterRule to keep order of rules
2 participants