Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gradle-plugin: add task to merge sarif reports #1456

Merged
merged 18 commits into from
Jul 25, 2022

Conversation

petertrr
Copy link
Member

@petertrr petertrr commented Jul 18, 2022

What's done:

  • Added task to merge SARIF reports

This pull request closes #1452

### What's done:
* Added task to merge SARIF reports
### What's done:
* Added task to merge SARIF reports
### What's done:
* Added task to merge SARIF reports
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 15 potential problems in the proposed changes. Check the Files changed tab for more details.

### What's done:
* Added task to merge SARIF reports
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 19 potential problems in the proposed changes. Check the Files changed tab for more details.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2022

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v1)

1 313 tests   1 297 ✔️  1m 57s ⏱️
   161 suites       16 💤
   161 files           0

Results for commit 2529777.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2022

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v1)

1 327 tests   1 312 ✔️  3m 0s ⏱️
   162 suites       15 💤
   162 files           0

Results for commit 2529777.

♻️ This comment has been updated with latest results.

@petertrr petertrr marked this pull request as draft July 18, 2022 15:37
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 24 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 24 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 24 potential problems in the proposed changes. Check the Files changed tab for more details.

@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #1456 (9f139d3) into master (40a51a9) will decrease coverage by 0.31%.
The diff coverage is 31.81%.

@@             Coverage Diff              @@
##             master    #1456      +/-   ##
============================================
- Coverage     83.27%   82.96%   -0.32%     
+ Complexity     2569     2567       -2     
============================================
  Files           110      111       +1     
  Lines          7661     7695      +34     
  Branches       2107     2112       +5     
============================================
+ Hits           6380     6384       +4     
- Misses          387      417      +30     
  Partials        894      894              
Flag Coverage Δ
unittests 82.96% <31.81%> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...diktat/plugin/gradle/tasks/SarifReportMergeTask.kt 18.91% <18.91%> (ø)
...rg/cqfn/diktat/plugin/gradle/DiktatGradlePlugin.kt 100.00% <100.00%> (ø)
...qfn/diktat/plugin/gradle/DiktatJavaExecTaskBase.kt 76.34% <100.00%> (-0.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40a51a9...9f139d3. Read the comment docs.

petertrr and others added 4 commits July 19, 2022 18:13
### What's done:
* Code style
…-reports#1452

# Conflicts:
#	diktat-gradle-plugin/src/main/kotlin/org/cqfn/diktat/plugin/gradle/DiktatJavaExecTaskBase.kt
#	diktat-gradle-plugin/src/main/kotlin/org/cqfn/diktat/plugin/gradle/Utils.kt
@orchestr7
Copy link
Member

Please add readme, no need to think about tests :)
We will test it manually

### What's done:
* Update README.md
* Aggregate only those tasks which have SARIF reporter enabled
@petertrr petertrr marked this pull request as ready for review July 22, 2022 12:14
@petertrr petertrr enabled auto-merge (squash) July 25, 2022 12:05
@petertrr petertrr merged commit befc9e9 into master Jul 25, 2022
@petertrr petertrr deleted the feature/merge-sarif-reports#1452 branch July 25, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge SARIF reports using diktat-gradle-plugin
3 participants