Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assertion failed in rule [kdoc-formatting] #1489 #1522

Merged
merged 4 commits into from
Sep 14, 2022

Conversation

icemachined
Copy link
Member

Assertion failed: anchorBefore == null || anchorBefore.getTreeParent() == parent in rule [kdoc-formatting] #1489

What's done:

  • fix for KDOC_WRONG_TAGS_ORDER rule
  • warning test "tags should be ordered assertion issue"
  • fix test "extra new line with tags ordering should not cause assert"

@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #1522 (5a63ae4) into master (95efc18) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #1522   +/-   ##
=========================================
  Coverage     82.55%   82.55%           
  Complexity     2577     2577           
=========================================
  Files           111      111           
  Lines          7735     7735           
  Branches       2125     2125           
=========================================
  Hits           6386     6386           
  Misses          443      443           
  Partials        906      906           
Flag Coverage Δ
unittests 82.55% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ktat/ruleset/rules/chapter2/kdoc/KdocFormatting.kt 85.06% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2022

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v1)

1 922 tests   1 907 ✔️  1m 34s ⏱️
   159 suites       15 💤
   159 files           0

Results for commit 5a63ae4.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2022

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v1)

1 937 tests   1 922 ✔️  3m 2s ⏱️
   160 suites       15 💤
   160 files           0

Results for commit 5a63ae4.

♻️ This comment has been updated with latest results.

@icemachined icemachined merged commit 52b4096 into master Sep 14, 2022
@icemachined icemachined deleted the bugfix/assertion branch September 14, 2022 21:45
@0x6675636b796f75676974687562 0x6675636b796f75676974687562 added this to the 1.2.4 milestone Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants