Only apply RANGE_TO_UNTIL rule if right-hand side of .. contains X-1
#1524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1524 +/- ##
=========================================
Coverage ? 82.56%
Complexity ? 2566
=========================================
Files ? 111
Lines ? 7716
Branches ? 2119
=========================================
Hits ? 6371
Misses ? 443
Partials ? 902
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…`X-1` ### What's done: * Fix logic * Minor refactorings * Add fix test case
petertrr
force-pushed
the
bugfix/peter.trifanov/range-rule#1502
branch
from
67ad125
to
8ceb012
Compare
nulls
approved these changes
Sep 14, 2022
0x6675636b796f75676974687562
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
This pull request closes #1502