Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLANK_LINE_BETWEEN_PROPERTIES false positive #1608

Merged
merged 2 commits into from
Feb 3, 2023

Conversation

Cheshiriks
Copy link
Member

What's done:

  • fixed isFollowedByNewlineCheck

Closes #1496

### What's done:
* fixed isFollowedByNewlineCheck

Closes #1496
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #1608 (f7b7740) into master (7954882) will decrease coverage by 0.01%.
The diff coverage is 80.00%.

@@             Coverage Diff              @@
##             master    #1608      +/-   ##
============================================
- Coverage     82.44%   82.44%   -0.01%     
  Complexity     2330     2330              
============================================
  Files           112      112              
  Lines          7856     7860       +4     
  Branches       2040     2043       +3     
============================================
+ Hits           6477     6480       +3     
  Misses          453      453              
- Partials        926      927       +1     
Flag Coverage Δ
unittests 82.44% <80.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tlin/org/cqfn/diktat/ruleset/utils/AstNodeUtils.kt 81.89% <80.00%> (-0.08%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

   165 files  ±0     165 suites  ±0   16m 16s ⏱️ - 8m 10s
2 011 tests +1  1 996 ✔️ +2  15 💤 ±0  0  - 1 
2 011 runs  ±0  1 996 ✔️ +1  15 💤 ±0  0  - 1 

Results for commit f7b7740. ± Comparison against base commit 7954882.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   33m 39s ⏱️ - 13m 9s
1 992 tests +1  1 973 ✔️ +1  15 💤 ±0  4 ±0 
1 996 runs  +1  1 977 ✔️ +1  15 💤 ±0  4 ±0 

For more details on these failures, see this check.

Results for commit f7b7740. ± Comparison against base commit 7954882.

♻️ This comment has been updated with latest results.

### What's done:
* fixed isFollowedByNewlineCheck

Closes #1496
@Cheshiriks Cheshiriks merged commit 22c1cdb into master Feb 3, 2023
@Cheshiriks Cheshiriks deleted the bugfix/single-line_comment branch February 3, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants