Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positive with single expression functions that use multiple return keywords #1617

Merged
merged 2 commits into from
Mar 14, 2023
Merged

False positive with single expression functions that use multiple return keywords #1617

merged 2 commits into from
Mar 14, 2023

Conversation

Cheshiriks
Copy link
Member

What's done:

  • added check for multiple return keywords

Closes #1588

@Cheshiriks
False positive with single expression functions that use multiple ret…
a9c980b 
…urn keywords

### What's done:
- added check for multiple return keywords

Closes #1588
@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2023 •
edited
Loading

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

2 014 tests   1 999 ✔️  17m 18s ⏱️
   165 suites       15 💤
   165 files           0 ❌

Results for commit ef7adf6.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2023 •
edited
Loading

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   164 files     164 suites   27m 57s ⏱️
1 995 tests 1 976 ✔️ 15 💤 4 ❌
1 999 runs  1 980 ✔️ 15 💤 4 ❌

For more details on these failures, see this check.

Results for commit ef7adf6.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Mar 13, 2023 •
edited
Loading

Codecov Report

Merging #1617 (ef7adf6) into master (bdc68db) will increase coverage by 0.02%.
The diff coverage is 57.14%.

@@             Coverage Diff              @@
##             master    #1617      +/-   ##
============================================
+ Coverage     82.44%   82.47%   +0.02%     
- Complexity     2330     2334       +4     
============================================
  Files           112      112              
  Lines          7860     7862       +2     
  Branches       2043     2045       +2     
============================================
+ Hits           6480     6484       +4     
+ Misses          453      452       -1     
+ Partials        927      926       -1
Flag Coverage Δ
unittests 82.47% <57.14%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kotlin/org/cqfn/diktat/ruleset/rules/DiktatRule.kt 66.66% <0.00%> (ø)
...tlin/org/cqfn/diktat/ruleset/utils/AstNodeUtils.kt 81.89% <0.00%> (ø)
.../ruleset/rules/chapter3/files/FileStructureRule.kt 85.35% <100.00%> (+0.58%) ⬆️
...iktat/ruleset/rules/chapter3/files/NewlinesRule.kt 81.86% <100.00%> (+0.31%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Cheshiriks Cheshiriks merged commit 4af545e into master Mar 14, 2023
@Cheshiriks Cheshiriks deleted the bugfix/single_expression_functions branch March 14, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nulls nulls nulls approved these changes

@0x6675636b796f75676974687562 0x6675636b796f75676974687562 Awaiting requested review from 0x6675636b796f75676974687562

@orchestr7 orchestr7 Awaiting requested review from orchestr7

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False positive with single expression functions that use multiple return keywords
2 participants
@Cheshiriks @nulls