Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency to mockito-all #1811

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Remove dependency to mockito-all #1811

merged 3 commits into from
Nov 21, 2023

Conversation

nulls
Copy link
Member

@nulls nulls commented Nov 21, 2023

What's done:

  • just remove dependency
  • refactored a test to avoid using Mockito since it's required Java 11

It closes #1753

### What's done:
- just remove dependency

It closes #1753
@nulls nulls self-assigned this Nov 21, 2023
@nulls nulls marked this pull request as ready for review November 21, 2023 12:16
@nulls nulls enabled auto-merge (squash) November 21, 2023 12:17
@nulls nulls disabled auto-merge November 21, 2023 12:30
@nulls nulls enabled auto-merge (squash) November 21, 2023 12:30
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ad37745) 78.39% compared to head (919db12) 78.39%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1811   +/-   ##
=========================================
  Coverage     78.39%   78.39%           
  Complexity     2432     2432           
=========================================
  Files           128      128           
  Lines          8578     8578           
  Branches       2151     2151           
=========================================
  Hits           6725     6725           
  Misses          893      893           
  Partials        960      960           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nulls nulls merged commit 15d2ad4 into master Nov 21, 2023
18 checks passed
@nulls nulls deleted the feature/mockito#1753 branch November 21, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to mockito
2 participants