Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mergeDiktatReports #1812

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Fix mergeDiktatReports #1812

merged 1 commit into from
Nov 21, 2023

Conversation

nulls
Copy link
Member

@nulls nulls commented Nov 21, 2023

What's done:

  • mustRunAfter instead of dependsOn to allow run mergeDiktatReports after failing diktatCheck

It closes #1733

### What's done:
- mustRunAfter instead of dependsOn to allow run `mergeDiktatReports` after failing diktatCheck

It closes #1733
@nulls nulls self-assigned this Nov 21, 2023
@nulls nulls enabled auto-merge (squash) November 21, 2023 13:49
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (15d2ad4) 78.39% compared to head (9d13204) 78.39%.

Files Patch % Lines
...diktat/plugin/gradle/tasks/SarifReportMergeTask.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1812   +/-   ##
=========================================
  Coverage     78.39%   78.39%           
  Complexity     2432     2432           
=========================================
  Files           128      128           
  Lines          8578     8578           
  Branches       2151     2151           
=========================================
  Hits           6725     6725           
  Misses          893      893           
  Partials        960      960           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   5m 9s ⏱️ -33s
1 393 tests ±0  1 357 ✔️ ±0  36 💤 ±0  0 ±0 
2 772 runs  ±0  2 736 ✔️ ±0  36 💤 ±0  0 ±0 

Results for commit 9d13204. ± Comparison against base commit 15d2ad4.

Copy link
Contributor

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   6m 48s ⏱️ -3s
1 393 tests ±0  1 376 ✔️ ±0  17 💤 ±0  0 ±0 
2 772 runs  ±0  2 755 ✔️ ±0  17 💤 ±0  0 ±0 

Results for commit 9d13204. ± Comparison against base commit 15d2ad4.

@nulls nulls merged commit 26bc29d into master Nov 21, 2023
20 of 21 checks passed
@nulls nulls deleted the feature/merge-sarif-reports#1733 branch November 21, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

diktat-gradle-plugin: add support for multiple reporters
2 participants