Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added shadow for diktat-runner #1834

Merged
merged 9 commits into from
Nov 30, 2023
Merged

Added shadow for diktat-runner #1834

merged 9 commits into from
Nov 30, 2023

Conversation

nulls
Copy link
Member

@nulls nulls commented Nov 29, 2023

What's done:

  • added shadow artifact for diktat-runner to resolve issue with guava in spotless

It's part of #1817

@nulls nulls self-assigned this Nov 29, 2023
@nulls nulls added this to the 2.0.0 milestone Nov 29, 2023
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (3ebe006) 78.18% compared to head (07b434a) 78.18%.

Files Patch % Lines
...c/main/kotlin/com/saveourtool/diktat/DiktatMain.kt 0.00% 1 Missing ⚠️
...lin/com/saveourtool/diktat/cli/DiktatProperties.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1834   +/-   ##
=========================================
  Coverage     78.18%   78.18%           
  Complexity     2425     2425           
=========================================
  Files           131      131           
  Lines          8631     8631           
  Branches       2174     2174           
=========================================
  Hits           6748     6748           
  Misses          917      917           
  Partials        966      966           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 29, 2023

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   7m 50s ⏱️ -20s
1 402 tests ±0  1 366 ✔️ ±0  36 💤 ±0  0 ±0 
2 781 runs  ±0  2 745 ✔️ ±0  36 💤 ±0  0 ±0 

Results for commit 07b434a. ± Comparison against base commit 3ebe006.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 29, 2023

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   6m 58s ⏱️ -12s
1 402 tests ±0  1 385 ✔️ ±0  17 💤 ±0  0 ±0 
2 781 runs  ±0  2 764 ✔️ ±0  17 💤 ±0  0 ±0 

Results for commit 07b434a. ± Comparison against base commit 3ebe006.

♻️ This comment has been updated with latest results.

@nulls nulls marked this pull request as ready for review November 30, 2023 08:06
@nulls nulls enabled auto-merge (squash) November 30, 2023 08:06
@nulls nulls merged commit 137b4f7 into master Nov 30, 2023
20 of 21 checks passed
@nulls nulls deleted the feature/support-spotless#1817 branch November 30, 2023 11:25
@nulls nulls linked an issue Nov 30, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Diktat 2.x in Spotless
2 participants