Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functional tests for diktat #312

Merged
merged 96 commits into from
Sep 25, 2020
Merged

Conversation

aktsay6
Copy link
Collaborator

@aktsay6 aktsay6 commented Sep 21, 2020

New action made to check if diktat works from cli/from maven/from gradle. Closes #299

Actions checklist

  • Implemented Rule, added Warnings
  • Added tests on checks
  • Added tests on fixers
  • Updated diktat-analysis.yml
  • Updated available-rules.md

@codecov
Copy link

codecov bot commented Sep 21, 2020

Codecov Report

Merging #312 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #312   +/-   ##
=========================================
  Coverage     82.29%   82.29%           
  Complexity     1016     1016           
=========================================
  Files            52       52           
  Lines          2627     2627           
  Branches        830      830           
=========================================
  Hits           2162     2162           
  Misses          169      169           
  Partials        296      296           
Flag Coverage Δ Complexity Δ
#unittests 82.29% <ø> (ø) 1016.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 471ded1...f812d20. Read the comment docs.

.github/workflows/functional_tests.yml Outdated Show resolved Hide resolved
.github/workflows/functional_tests.yml Outdated Show resolved Hide resolved
@aktsay6 aktsay6 marked this pull request as ready for review September 22, 2020 14:10
Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now you need to make this check green by checking output of all commands and somehow checking if they failed or diktat found errors.

@aktsay6 aktsay6 marked this pull request as draft September 22, 2020 14:54
@aktsay6 aktsay6 marked this pull request as ready for review September 25, 2020 11:56
@aktsay6 aktsay6 requested a review from petertrr September 25, 2020 11:56
Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I suggest to move FunctionalTestFile to test resources

.github/workflows/functional_tests.yml Outdated Show resolved Hide resolved
Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aktsay6 aktsay6 merged commit b733074 into master Sep 25, 2020
@aktsay6 aktsay6 deleted the feature/functional-tests-on-diktat branch September 25, 2020 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add functional tests for diktat
2 participants