-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functional tests for diktat #312
Conversation
Codecov Report
@@ Coverage Diff @@
## master #312 +/- ##
=========================================
Coverage 82.29% 82.29%
Complexity 1016 1016
=========================================
Files 52 52
Lines 2627 2627
Branches 830 830
=========================================
Hits 2162 2162
Misses 169 169
Partials 296 296
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
### What's done: * Fixed bugs
…at' into feature/functional-tests-on-diktat
### What's done: * Fixed bugs
…at' into feature/functional-tests-on-diktat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now you need to make this check green by checking output of all commands and somehow checking if they failed or diktat found errors.
### What's done: * Added functional class
…at' into feature/functional-tests-on-diktat
### What's done: * Added functional class
### What's done: * Added functional class to gradle
…at' into feature/functional-tests-on-diktat
### What's done: * Fixed bugs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I suggest to move FunctionalTestFile
to test resources
### What's done: * Remade pom
### What's done: * Fixed bugs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
New action made to check if diktat works from cli/from maven/from gradle. Closes #299
Actions checklist