Making diktat consistent with own code style #318
Conversation
### What's done: * Code style
### What's done: * Code style
Codecov Report
@@ Coverage Diff @@
## master #318 +/- ##
=========================================
Coverage 82.29% 82.30%
Complexity 1016 1016
=========================================
Files 52 52
Lines 2627 2628 +1
Branches 830 830
=========================================
+ Hits 2162 2163 +1
Misses 169 169
Partials 296 296
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
### What's done: * Code style
### What's done: * Code style
### What's done: * Update diktat_snapshot.yml
### What's done: * Update diktat_snapshot.yml
### What's done: * Update diktat_snapshot.yml
### What's done: * Update diktat_snapshot.yml
### What's done: * Update diktat_snapshot.yml
| (it.findChildByType(MODIFIER_LIST) == null || it.findLeafWithSpecificType(PRIVATE_KEYWORD) != null) | ||
| && it.getIdentifierName()!!.text.contains(loggerPropertyRegex) | ||
| }.toMutableList() | ||
| val loggers = allProperties |
There was a problem hiding this comment.
I guess we will need to change this logic:
allProperties.filter
.foo()
.bar()
is valid
There was a problem hiding this comment.
So like if first call in chain is multiline lamba, then it should start on the same line as initial receiver?
There was a problem hiding this comment.
that should be possible, not prohibited. Both cases should be valid:
a.foo
.foo
a
.foo
.foo
but a.foo.foo is invalid
...framework/src/main/kotlin/org/cqfn/diktat/test/framework/processing/TestProcessingFactory.kt
Show resolved
Hide resolved
| run: | | ||
| mvn -B install -DskipTests=true | ||
| mvn -B antrun:run@diktat --pl diktat-common || echo "LintErrors encountered" | ||
| mvn -B antrun:run@diktat --pl diktat-test-framework || echo "LintErrors encountered" |
There was a problem hiding this comment.
but why not to make echo "LintErrors encountered in test-framework"
"in diktat", e.t.c
There was a problem hiding this comment.
I just thought it would be a small line in build log, used as a workaround to continue after error, and the important information is in maven output
What's done:
Related issue #33
Issues discovered:
#317#320 #321 #324 #325