Rule 4.1.2: Numbers of a float type should not be directly compared #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Initial implementation * Tests
…float-ariphmethic
### What's done: * Update yml files and available-rules.md
### What's done: * Added new rule to DiktatRuleSetProvider * Added maven central badge
### What's done: * Fixes
…float-ariphmethic # Conflicts: # diktat-analysis.yml # diktat-rules/src/main/kotlin/generated/WarningNames.kt # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/constants/Warnings.kt # diktat-rules/src/main/resources/diktat-analysis-huawei.yml # diktat-rules/src/main/resources/diktat-analysis.yml # info/available-rules.md
### What's done: * Fixes
### What's done: * Rule 4.1.2
Codecov Report
@@ Coverage Diff @@
## master #323 +/- ##
============================================
- Coverage 82.81% 82.73% -0.08%
- Complexity 1187 1214 +27
============================================
Files 59 59
Lines 2950 2989 +39
Branches 934 952 +18
============================================
+ Hits 2443 2473 +30
- Misses 169 171 +2
- Partials 338 345 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Base automatically changed from
feature/rule-4.1.1-float-ariphmethic
to
master
September 24, 2020 19:37
# Conflicts: # diktat-analysis.yml # diktat-rules/src/main/kotlin/generated/WarningNames.kt # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/constants/Warnings.kt # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/calculations/AccurateCalculationsRule.kt # diktat-rules/src/main/resources/diktat-analysis-huawei.yml # diktat-rules/src/main/resources/diktat-analysis.yml # diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/chapter4/AccurateCalculationsWarnTest.kt
### What's done: * Rule 4.1.2
orchestr7
changed the title
### What's done: * Code style
orchestr7
reviewed
Sep 30, 2020
diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/chapter4/AccurateCalculationsWarnTest.kt
Show resolved
Hide resolved
### What's done: * Tests with ==
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
This pull request closes #290