Handling custom property accessors in formatting rules #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Updated IndentationRule * Updated ClassLikeStructuresOrderRule * Added tests
Codecov Report
@@ Coverage Diff @@
## master #337 +/- ##
=========================================
Coverage 81.76% 81.76%
- Complexity 1093 1102 +9
=========================================
Files 54 54
Lines 2786 2797 +11
Branches 884 890 +6
=========================================
+ Hits 2278 2287 +9
Misses 183 183
- Partials 325 327 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
kentr0w
approved these changes
Sep 29, 2020
| val numRequiredNewLines = 1 + (if (isBlankLineRequired) 1 else 0) | ||
| val actualNewLines = whiteSpaceBefore.text.count { it == '\n' } | ||
| // for some cases we do not check strict number of blank lines, but allow actual number to be less or equal | ||
| val isLessLinesAllowed = hasCustomAccessors |
There was a problem hiding this comment.
I think you can inline this variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
This pull request closes #320