Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assignment operator increases indent with extened option #338

Merged
merged 4 commits into from
Sep 30, 2020

Conversation

petertrr
Copy link
Member

What's done:

  • Updated logic
  • Added tests

This pull request closes #239

### What's done:
* Updated logic
* Added tests
@codecov
Copy link

codecov bot commented Sep 29, 2020

Codecov Report

Merging #338 into master will decrease coverage by 0.05%.
The diff coverage is 60.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #338      +/-   ##
============================================
- Coverage     82.88%   82.82%   -0.06%     
- Complexity     1125     1127       +2     
============================================
  Files            54       54              
  Lines          2798     2800       +2     
  Branches        890      893       +3     
============================================
  Hits           2319     2319              
  Misses          162      162              
- Partials        317      319       +2     
Flag Coverage Δ Complexity Δ
#unittests 82.82% <60.00%> (-0.06%) 1127.00 <0.00> (+2.00) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
.../cqfn/diktat/ruleset/utils/indentation/Checkers.kt 71.42% <0.00%> (-1.43%) 0.00 <0.00> (ø)
...cqfn/diktat/ruleset/rules/files/IndentationRule.kt 89.61% <75.00%> (+0.27%) 23.00 <0.00> (+3.00)
...tat/ruleset/utils/indentation/IndentationConfig.kt 50.00% <0.00%> (-16.67%) 8.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff91017...f29f549. Read the comment docs.

Copy link
Member

@orchestr7 orchestr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@petertrr petertrr merged commit 7030f70 into master Sep 30, 2020
@petertrr petertrr deleted the feature/extended-indent-after-assignment#239 branch September 30, 2020 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In IndentationRule extendedIndentAfterOperators option doesn't affect assignment
2 participants