Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/table-of-contents #388

Merged
merged 5 commits into from
Oct 15, 2020
Merged

feature/table-of-contents #388

merged 5 commits into from
Oct 15, 2020

Conversation

aktsay6
Copy link
Collaborator

@aktsay6 aktsay6 commented Oct 12, 2020

What's done:

  • Table of contents made

This pull request closes #373

Actions checklist

  • Implemented Rule, added Warnings
  • Added tests on checks
  • Added tests on fixers
  • Updated diktat-analysis.yml
  • Updated available-rules.md

### What's done:
  * Table of contents made
@aktsay6 aktsay6 added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 12, 2020
@aktsay6 aktsay6 requested review from kentr0w and orchestr7 October 12, 2020 12:00
@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #388 into master will increase coverage by 0.53%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #388      +/-   ##
============================================
+ Coverage     82.55%   83.09%   +0.53%     
+ Complexity     1340     1289      -51     
============================================
  Files            65       64       -1     
  Lines          3251     3147     -104     
  Branches       1042      999      -43     
============================================
- Hits           2684     2615      -69     
+ Misses          177      168       -9     
+ Partials        390      364      -26     
Flag Coverage Δ Complexity Δ
#unittests 83.09% <ø> (+0.53%) 1289.00 <ø> (-51.00) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
.../kotlin/org/cqfn/diktat/ruleset/utils/KDocUtils.kt 6.66% <0.00%> (-18.34%) 0.00% <0.00%> (ø%)
...fn/diktat/ruleset/rules/files/FileStructureRule.kt 57.89% <0.00%> (-2.11%) 19.00% <0.00%> (-1.00%)
...fn/diktat/ruleset/rules/StringConcatenationRule.kt 82.35% <0.00%> (-0.99%) 15.00% <0.00%> (ø%)
.../org/cqfn/diktat/ruleset/rules/kdoc/KdocMethods.kt 90.52% <0.00%> (-0.20%) 69.00% <0.00%> (ø%)
...g/cqfn/diktat/ruleset/rules/kdoc/KdocFormatting.kt 75.53% <0.00%> (-0.18%) 75.00% <0.00%> (+2.00%) ⬇️
...tlin/org/cqfn/diktat/ruleset/constants/Warnings.kt 97.05% <0.00%> (-0.06%) 9.00% <0.00%> (ø%)
...cqfn/diktat/ruleset/rules/DiktatRuleSetProvider.kt 98.07% <0.00%> (-0.04%) 3.00% <0.00%> (ø%)
...ktat/ruleset/rules/OverloadingArgumentsFunction.kt
...qfn/diktat/ruleset/utils/search/VariablesSearch.kt 86.20% <0.00%> (+0.49%) 18.00% <0.00%> (ø%)
...tlin/org/cqfn/diktat/ruleset/utils/AstNodeUtils.kt 82.74% <0.00%> (+0.50%) 0.00% <0.00%> (ø%)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 819b631...3468fd7. Read the comment docs.

wp/tableOfContent.tex Outdated Show resolved Hide resolved
wp/tableOfContent.tex Outdated Show resolved Hide resolved
### What's done:
  * Fixed bugs
@aktsay6 aktsay6 requested a review from orchestr7 October 14, 2020 09:37
aktsay6 and others added 3 commits October 14, 2020 12:40
### What's done:
  * Removed tableOfContent.tex and added it to wp.tex
Copy link
Member

@orchestr7 orchestr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@orchestr7 orchestr7 merged commit ddc478d into master Oct 15, 2020
@petertrr petertrr added this to the diKTat whitepaper milestone Oct 19, 2020
@petertrr petertrr deleted the feature/table-of-contents branch October 22, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Whitepaper: fork from aibolit and create a table of content
3 participants