Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wildcard without "import" word #392

Merged
merged 4 commits into from
Oct 13, 2020
Merged

Conversation

kentr0w
Copy link
Collaborator

@kentr0w kentr0w commented Oct 13, 2020

What's done:

Fixed bug
closes #379

### What's done:
    Fixed bug
@kentr0w kentr0w added the bug Something isn't working label Oct 13, 2020
@codecov
Copy link

codecov bot commented Oct 13, 2020

Codecov Report

Merging #392 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #392      +/-   ##
============================================
+ Coverage     83.14%   83.16%   +0.01%     
  Complexity     1331     1331              
============================================
  Files            65       65              
  Lines          3246     3249       +3     
  Branches       1027     1027              
============================================
+ Hits           2699     2702       +3     
  Misses          176      176              
  Partials        371      371              
Flag Coverage Δ Complexity Δ
#unittests 83.16% <100.00%> (+0.01%) 1331.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...fn/diktat/ruleset/rules/files/FileStructureRule.kt 60.00% <100.00%> (+2.10%) 19.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20cb97b...49bfddd. Read the comment docs.

Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kentr0w kentr0w merged commit dcc073b into master Oct 13, 2020
@kentr0w kentr0w deleted the bugfix/wildcard-without-import branch October 13, 2020 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wildcard imports option should have format 'path.to.dependency.*' and not 'import path.to.dependency.*'
2 participants