Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing customizations of KTlint as much as possible ... #4

Merged
merged 1 commit into from
Jul 2, 2020

Conversation

orchestr7
Copy link
Member

from diktat to be able to move the project in separate repo.

What's done:

  1. Mainly rules-config.json handling was changed. Now it is integrated in code and should not be passed as separate config.
  2. Tests were change, readme updated.

Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, but if we merge #1 first, those changes will need to be merged here too.

…be able to move the project in separate repo.

### What's done:
1) Mainly rules-config.json handling was changed. Now it is integrated in code and should not be passed as separate config.
2) Tests were change, readme updated.
@orchestr7 orchestr7 force-pushed the feature/ktlint-fork branch from 5535df9 to 028d259 Compare July 2, 2020 15:46
@petertrr petertrr merged commit 398bf1d into master Jul 2, 2020
@petertrr petertrr deleted the feature/ktlint-fork branch July 2, 2020 15:54
@orchestr7 orchestr7 self-assigned this Jul 4, 2020
@orchestr7 orchestr7 added the enhancement New feature or request label Jul 4, 2020
petertrr pushed a commit that referenced this pull request Jul 31, 2020
…be able to move the project in separate repo. (#4)

### What's done:
1) Mainly rules-config.json handling was changed. Now it is integrated in code and should not be passed as separate config.
2) Tests were change, readme updated.
nulls added a commit that referenced this pull request Oct 28, 2022
nulls added a commit that referenced this pull request Nov 15, 2022
nulls added a commit that referenced this pull request Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants