Added logic for parameters and supertypes lists to NewlinesRule #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Changed logic * Added tests * Updated code style guide
### What's done: * Code style
…feature/newlines-rule#420
Codecov Report
@@ Coverage Diff @@
## master #431 +/- ##
============================================
- Coverage 81.97% 81.87% -0.10%
- Complexity 1464 1478 +14
============================================
Files 71 71
Lines 3689 3730 +41
Branches 1178 1195 +17
============================================
+ Hits 3024 3054 +30
- Misses 201 203 +2
- Partials 464 473 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
### What's done: * Code style
kentr0w
requested changes
Oct 21, 2020
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/files/NewlinesRule.kt
Show resolved
Hide resolved
orchestr7
reviewed
Oct 26, 2020
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/files/NewlinesRule.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
This pull request closes #420
Actions checklist